[EngineIgnitor] fix for remaining ignitions having a higher value than available ignitions on some engine configs#1582
Open
mountainparrot wants to merge 2 commits into
Conversation
Collaborator
|
I'm pretty sure base j2 is meant to have 2, with j2s having 3, but that's just based on what RO does. A functional difference in the tech upgrade from j2 to j2s isnt bad to have anyway imo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also wasn't sure why the base J2 config had only 2 available ignitions so I've bumped it back up to 3